View source for MediaWiki talk:Gadget-popups.js

{{caution|This page is for gadget-specific discussion. For most issues, please visit [[Wikipedia talk:Tools/Navigation popups]]. This gadget also has a [https://phabricator.wikimedia.org/project/board/2055/ Phabricator workboard] used for implementation-related discussion.}}
{{central|MediaWiki talk:Gadget-navpop.css}}
{{archives|banner=yes|bot=Lowercase sigmabot III|age=1|units=year}}
{{Wikipedia:Tools/Navigation popups/Navbox}}
{{User:MiszaBot/config
| algo                = old(365d)
| archive             = MediaWiki talk:Gadget-popups.js/Archive %(counter)d
| counter             = 3
| maxarchivesize      = 150K
| archiveheader       = {{Automatic archive navigator}}
| minthreadstoarchive = 1
| minthreadsleft      = 4
}}
__TOC__

== MediaWiki:Gadget-navpop.css should be renamed to MediaWiki:Gadget-popups.css ==

This gadget uses a second file called [[MediaWiki:Gadget-navpop.css]]. Idea: Shouldn't have to look at the gadgets definition file to figure out what this gadget's CSS file is named. It'd probably make more sense for all files related to this gadget to start with MediaWiki:Gadget-popups. So I propose renaming MediaWiki:Gadget-navpop.css to MediaWiki:Gadget-popups.css –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 10:34, 15 August 2023 (UTC)

:'''Support'''. No reason in having this oddity. <span style="background:#ffff55">'''''[[User:Chlod|Chlod]]'''''</span>&nbsp;<small style="font-size:calc(1em - 2pt)">([[User talk:Chlod|say&nbsp;hi!]])</small> 14:48, 18 August 2023 (UTC)
:I’m not opposed to the renaming, but please make sure to maintain backward compatibility. There are probably quite a few people and wikis who load the NavPopups CSS directly rather than as part of the ResourceLoader module, so it’s important that https://en.wikipedia.org/enwiki/w/index.php?title=MediaWiki:Gadget-navpop.css&action=raw&ctype=text/css continues to load the necessary styles. —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 17:22, 19 August 2023 (UTC)
::@[[User:Tacsipacsi|Tacsipacsi]]. Would replacing [[MediaWiki:Gadget-navpop.css]] with <code>importStylesheet('MediaWiki:Gadget-popups.css');</code> be an acceptable solution? –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 20:47, 7 December 2023 (UTC)
:::{{reply to|Novem Linguae}} Apart from it not working, yes. 🙂 You try to put JavaScript in a CSS file, which of course won’t work, but a working solution along these lines would be acceptable. Please also make sure to use absolute URLs because many – probably even most – affected imports are not on the English Wikipedia (<code>importStylesheet</code> uses a URL relative to the wiki it’s executed on, not to the wiki it’s defined on, which would be wrong). —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 15:25, 8 December 2023 (UTC)

== Use native string repetition function ==

{{edit interface-protected|MediaWiki:Gadget-popups.js|answered=yes}}

This gadget uses custom string repetition function. It should be replaced with native [https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat String.prototype.repeat()] which is significantly faster and well supported by modern browsers. – [[User:Ammarpad|Ammarpad]] ([[User talk:Ammarpad|talk]]) 05:20, 20 September 2023 (UTC)

:It seems to be used only for formatting time. So it would probably only help in optimization of the history page preview (if at all significant). Not sure if that is something worth optimizing. You know "premature optimization..." etc [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 22:51, 24 September 2023 (UTC)
::I see this as more refactoring than optimizing. I have no objections to the idea. But it needs someone to write and test the patch. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 23:42, 24 September 2023 (UTC)
:::Refactoring when you loose compatibly, do a lot of work and gain nothing in practice is a bad idea IMHO. When you would start refactoring that you would never finish ;). When you go up the stack you also have a custom `map` function. [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 11:50, 25 September 2023 (UTC)
::::If both behave identically, using internal functions is always better than writing your own. 1) More standardized so more readable. 2) Less lines of code. 3) More performant. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 19:33, 1 December 2023 (UTC)
:::To be a bit more constructive here... I think a better refactoring effort might be to be to move Popups to Github (e.g. with [[Wikipedia:Wiki-to-Git]]). Then do a split to separate files. And then either use e.g. browserify to combine it again. I've been thinking abut this for a while for plwiki, not sure if such update would be accepted here. [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 12:19, 25 September 2023 (UTC)
::::I'd be open to this if this page gets more activity. With current activity levels though, moving to GitHub may just result in the GitHub being neglected and the versions getting out of sync. And also adds deploy complexity. https://github.com/wikimedia-gadgets/ would be a good spot for this if popups development gets more active (more folks working on this would justify the added complexity of an off-site repo). –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 19:36, 1 December 2023 (UTC)
:{{not done}} this doesn't appear to be a ready-to-go release, and may need additional discussion as well. Please prepare a current version to proposed version in a sandbox, such as at [[Special:MyPage/Gadget-popups-sandbox.js]] for the proposed code. IF this section is just to discuss strategies and proposals of course you may continue the discussion below. Best regards, — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 03:17, 8 October 2023 (UTC)

== Live preview refactor ==
@[[User:Novem Linguae|Novem Linguae]] I've done another round of refactoring and have ended up with [[Special:Diff/1188512287/1188515243|this diff]]. The salient highlights are:
* Removed the custom wikitext parsing engine at <code>wiki2html()</code> and replaced it a call to the parsing API
* Removed <code>defaultPopupsContainer()</code> and replaced it with a lookup to <code>#mw-content-text</code> (since that is the [[mw:ResourceLoader/Core modules#$content|stable way]] to identify where the content starts)
* Refactored the <code>generateLink()</code> to not use raw HTML manipulation
[[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 22:37, 5 December 2023 (UTC)
:You shouldn't remove `defaultPopupsContainer`. You should add new selector on top of the selectors, not remove fallbacks. You've also removed `popupOnlyArticleLinks` options by removing `defaultPopupsContainer`. I use popus on e.g. history tab. [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 23:28, 5 December 2023 (UTC)
::I've added back the function in my version, the updated diff should be [[Special:Diff/1188512287/1188522515|this]] (lmk if you find any other issues). That being said, I did test the refactoring on quite a few cases (including the history tab, edit and preview usecases) and did not find any noticable difference in behaviour with <code>#mw-content-text</code>. [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 23:45, 5 December 2023 (UTC)
:::Thanks. I like the idea behind the changes. So I hope you don't mind me looking over your shoulder, but this is a popular gadget, which I'm also using :). Some thoughts upon review:
:::# `<code>.bind( this )</code>` is not needed most of the time. The `<code>this</code>` keyword is not used inside of most calls to `<code>makePreview</code>`.
:::# `<code>APIimagepagePreviewHTML</code>` doesn't have the same flow. At least looking at the code after `<code>if (typeof content === 'string')</code>` is another if (not else if). So `<code>return ret;</code>` below will not be correct (probably, quite likely).
:::# `<code>APIsharedImagePagePreviewHTML</code>` is in `<code>pg.fn</code>`, so it is exposed to other gadgets and user scripts (possibly scripts on meta.wiki). Not sure if you can just change it from a synchronous function to async. I would at least expose the <code>Promise</code>.
:::# This is mostly nit picking, but I think `<code>// STARTFILE: livepreview.js</code>` should be preserved. I still hope some bold dev, with admin rights, will one day cut the code to files ;).
:::In any case, I think large changes like this should go through beta process. Even if the code would mostly be equivalent, there might be some cases that are not easy to test. [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 00:10, 6 December 2023 (UTC)
::::@[[User:Sohom Datta|Sohom Datta]] I also noticed I think you've missed how <code>htmlGenerator</code> is used. Seems like <code>showAPIPreview</code> shouldn't work. Seems to expect non-async function. [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 00:34, 6 December 2023 (UTC)
:::::@[[User:Nux|Nux]] No issues, in fact the more issues we find the better :)
:::::* I've gone ahead and fixed the issue with <code>APIimagepagePreviewHTML</code> (lmk if there are any issues)
:::::* I did a [https://global-search.toolforge.org/?q=APIsharedImagePagePreviewHTML&namespaces=2%2C4%2C8&title=%28Gadgets-definition%7C.*%5C.%28js%7Ccss%7Cjson%29%29 global search] for <code>APIsharedImagePagePreviewHTML</code> and the only instances are popup clones, so I'm assuming this should be fine.
:::::* I've added <code>// STARTFILE: livepreview.js</code> though, only the wrapper wiki2html function remains.
:::::* I've removed the unnecessary <code>.bind( this )</code> calls :)
:::::Regarding the beta process, I'm happy to wait a while for y'all to test and review the code. I'll put up a post at [[WP:VPT]] and [[WP:IANB]] to solicit more beta testers/people who might want to review the code :) [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 00:56, 6 December 2023 (UTC)
::::::For anyone willing to betatest this, please disable the gadget in your settings and add the following to your common.js
::::::<syntaxhighlight lang="js">
importStylesheet( 'MediaWiki:gadget-navpop.css' );
importScript('User:Sohom_Datta/popups.js');
</syntaxhighlight> [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 01:05, 6 December 2023 (UTC)
:::::::The gadget definition is
:::::::<syntaxhighlight>Navigation_popups[ResourceLoader|dependencies=mediawiki.api,mediawiki.user,mediawiki.util,user.options,mediawiki.jqueryMsg|type=general]|popups.js|navpop.css</syntaxhighlight>
:::::::So we probably need something more like this for testing, right? ("w:" added so that this works on testwiki)
:::::::<syntaxhighlight lang="js">mw.loader.using(['mediawiki.api', 'mediawiki.user', 'mediawiki.util', 'user.options', 'mediawiki.jqueryMsg']).then(function() {
	importScript('w:User:Sohom_Datta/popups.js');
	importStylesheet('w:MediaWiki:Gadget-navpop.css');
});</syntaxhighlight> –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 06:16, 6 December 2023 (UTC)
:::::::Very nice work. Getting rid of the 769 lines of InstaView code (which is some of the smellier code in the codebase, with one letter variable names, <code>for (; remain(); )</code>, etc.) is definitely a maintainability win.
:::::::May I suggest splitting this into three patches? Want to diff out the "Removed the custom wikitext parsing engine at wiki2html() and replaced it a call to the parsing API" in a new section and tag it with {{t|IAER}}? Smaller patches spaced out over time means easier testing, and easier to tell what caused bugs if this talk page starts getting bug reports. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 07:43, 6 December 2023 (UTC)
:::One thing this will complicate might be section previews. Take for instance [[Wikipedia:Writing better articles#Tone|formal tone]]. We also have to think about other content models like [[User:TheDJ/common.css]] and analyze a bit the performance for very big pages, with something like [[Barack Obama]]. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 08:29, 6 December 2023 (UTC)
::::@[[User:TheDJ|TheDJ]] Section previews appears to work similarly to how it worked previously. [[User:TheDJ/common.css]] does fail, but it does so on the old navpopups code as well (we should fix that in a later request?). [[Barack Obama]] seems fine since Navpopups truncates the preview to only show a small portion of the wikitext before it reaches the preview code. There is some additional latency since we are moving to a API call from a synchronous parsing of HTML, but overall it should be a performance win if we are parsing long peices of wikitext since we are keeping the main thread free instead of busy parsing multiple bytes of wikitext :) [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 10:48, 6 December 2023 (UTC)

== Create a GitHub repo? ==

I guess if Sohom is going to be submitting complex patches like the above, it might be time to think about moving to a GitHub repo. I'm still not completely sold on it, but wanted to start a discussion. Here's some of my thoughts: [[User:Novem Linguae/Essays/Pros and cons of moving a gadget to a repo]]. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 08:00, 6 December 2023 (UTC)

:gitlab.wikimedia.org —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 08:16, 6 December 2023 (UTC)
:I would add ''copyright'' to pros. Most of the time, I see patches applied, admins don't use the name of the person who authored the patch. Most of the time, patches are small, but for bigger patches, that might be copyvio. I assume when exporting one would use [[Wikipedia:Wiki-to-Git]] or similar to preserve authors :) (at least authors applying patches). And then when you do pull requests the authors are automatically preserved.
:Also to pros I would add ''blame''. Use that very often to figure when and why particular code was added. Making blame work after splitting to files might be a bit hard on git (no built in copy function). But there are ways to do that with a bit of branch and merge magic. [[User:Nux|Nux]] <small>([[User_talk:Nux|talk]])</small> 10:35, 6 December 2023 (UTC)
::I would definitely support a repository. Amongst other things, it will allow for much better code review. Another nice feature would be the ability to migrate to a sane linting system and potentially migrating to using the ResourceLoader package file system in the future (instead of one <s>big</s> huge 8000 line file).
::I don't have any issues with eithier Wikimedia Gitlab or Github (as long as Gerrit is not considered), though it might be worthwhile to ask for a specific <code>repos/gadgets</code> namespace in Gitlab if we want to do it longterm :) [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 11:35, 6 December 2023 (UTC)
:::How will visibility concerns be addressed? Where will changes be discussed? Will the .js code overleaf always be the live code? -- [[User:Michael Bednarek|Michael Bednarek]] ([[User talk:Michael Bednarek|talk]]) 12:37, 6 December 2023 (UTC)
::::@[[User:Michael Bednarek|Michael Bednarek]] I don't think there are any visibility issues as such, the code needs to be onwiki and in plaintext for the gadget to be able to run at all regardless of whether we use a single huge file or multiple small files with the packagefile directive. Regarding the code review process, it would happen primarily on the platform Gitlab/Github similar to how the Twinkle code review model currently works. [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 14:47, 6 December 2023 (UTC)
:::::While code review would happen on GitLab, reporting bugs and requesting features could continue to happen here on Wikipedia, as issues are intentionally disabled on gitlab.wikimedia.org. (I prefer gitlab.wikimedia.org to GitHub to keep the code in-house and make it easier to link Git users to Wikipedia users.) —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 15:28, 8 December 2023 (UTC)

== Refactor parsing of wikitext ==

{{IAER|answered=yes}}
Per the above discussion, the following changes [https://en.wikipedia.org/enwiki/w/index.php?title=User%3ASohom_Datta%2Fparsingchange-popups.js&diff=1188589175&oldid=1188589050] are proposed :) [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 11:02, 6 December 2023 (UTC)

:This is just the "Removed the custom wikitext parsing engine at wiki2html() and replaced it a call to the parsing API" part of your above code, and not the other two items, correct? Also, what is a good test procedure for this? –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 11:15, 6 December 2023 (UTC)
::Yep, it is only that wrt to testing,
::<syntaxhighlight lang="js">
mw.loader.using(['mediawiki.api', 'mediawiki.user', 'mediawiki.util', 'user.options', 'mediawiki.jqueryMsg']).then(function() {
	importScript('w:User:Sohom Datta/parsingchange-popups.js');
	importStylesheet('w:MediaWiki:Gadget-navpop.css');
});
</syntaxhighlight>
::should work :) [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 11:17, 6 December 2023 (UTC)
:::For testing, I meant, what modules should we be clicking to exercise this part of the code? :) –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 11:31, 6 December 2023 (UTC)
::::Oh, okay :) Since this is the preview module, anything that shows a preview would work (articles, userpages, images). I've put together a set of links at [[User:Sohom_Datta/sandy-box]] in case you want to test it out :) [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 11:55, 6 December 2023 (UTC)
:::::Sandy box. Love that. Haha. In my testing, I found two differences between the old and the new.
:::::# Templates now render, instead of displaying the wikicode. You can see this in your sandy box image examples. I think this is a feature not a bug. I think folks will like this. {{tick}}
:::::# Headings now have [ edit | edit section ] links that they didn't have before. And they are showing up a bit too big. I think they are the same size as the headings rather than body text. I think this should either be shrunk or hidden before we deploy this patch. This may involve changing [[MediaWiki:Gadget-navpop.css]]. {{Cross}}
:::::# Now that the other patch was merged, needs a rebase. {{Cross}}
:::::–[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 20:27, 7 December 2023 (UTC)
::::::I won’t like if templates are rendered. Templates are not rendered for a reason: how templates making heavy use of parameters happen to render on their own page doesn’t say much about what they’re really are. They are oftentimes even partly or entirely <code>&lt;includeonly&gt;</code>d, so parts are left out from the preview. Couldn’t the namespace condition moved to before making the API request, so that the request is sent only for non-template pages, continuing to display template wikitext verbatim? —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 15:37, 8 December 2023 (UTC)
:::::::I intend to take another stab at this next week, it seems to be fairly complicated to have templates not be rendered, I will see if we can maybe only the show the documentation somehow. [[User:Sohom Datta|Sohom]] ([[User talk:Sohom Datta|talk]]) 15:59, 15 December 2023 (UTC)

== Article title hyperlinks in previews are black, not blue ==

Steps to reproduce: 1) vector 2010, not tested on other skins, 2) turn off navigation popups in [[Special:Preferences]] gadgets, 3) add the below code to User:abc/common.js, 4) hover over a valid article. What happens? Article title link is black. What should happen instead? Article title link is blue.

<syntaxhighlight lang="js">mw.loader.using(['mediawiki.api', 'mediawiki.user', 'mediawiki.util', 'user.options', 'mediawiki.jqueryMsg']).then(function() {
	importScript('w:User:Sohom Datta/parsingchange-popups.js');
	importStylesheet('w:MediaWiki:Gadget-navpop.css');
});</syntaxhighlight>

Looking at the code for <code>.popup_mainlink a { color: #000; }</code>, I think the devs intend for it to be black everywhere.

In the situation above, there are two CSS styles competing with each other. In one situation, <code>.popup_mainlink a { color: #000; }</code> wins out over the other styles. In the other situation, <code>a:link, .mw-parser-output a.extiw, .mw-parser-output a.external, .vector-menu-portal .vector-menu-content li a { color: rgb(0,0,238); }</code> wins out over the other styles.

Anyway, I think we should pick one color, then get it to be used consistently. Whether it's blue or black. I'm leaning blue.

I'm also curious why loading it as a non-gadget changes the CSS order of precedence, even though the two sets of selectors are identical. Perhaps there's a bug in the load code above? –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 20:37, 7 December 2023 (UTC)

== Other talk page, and Phabricator ==

Looks like this gadget has another talk page at [[Wikipedia talk:Tools/Navigation popups]], and also a [https://phabricator.wikimedia.org/project/profile/2055/ tag on Phabricator]. Just an FYI for folks who only know about this page. I only discovered these today. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 08:20, 30 December 2023 (UTC)

== History preview failed ==

can we change:

<code>return 'History preview failed :-(';</code>

to something like:

<code>return popupString('History preview failed :-(');</code>

for localization purpose? [[User:Valepert|valepert]] ([[User talk:Valepert|talk]]) 10:22, 31 January 2024 (UTC)

:Want to sandbox it somewhere and make sure it works? Then tag this with {{t|IAER}}? Also, searching for "preview failed" reviews 5 spots we could apply this pattern to. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 10:29, 31 January 2024 (UTC)
::I made some test [[User:Valepert/popup.js|here]], without CSS, and hovering "hist" on [[Special:Contributions/2A02:C7F:745F:6400:69E1:8FB2:A675:2199|this page]]. I hope it's enough to evaluate the change. --[[User:Valepert|valepert]] ([[User talk:Valepert|talk]]) 13:57, 31 January 2024 (UTC)
:::@[[User:Valepert|Valepert]]. Don't forget to tag this with {{t|IAER}} when it's ready to go. Also please provide a steps to test, and a diff of what you changed. This makes it easy for the reviewer. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 22:36, 28 February 2024 (UTC)

{{Edit interface-protected|answered=yes}}
:please change "'History preview failed :-('" with "popupString('History preview failed')", adding "'History preview failed': 'History preview failed :-('," before "last:".
:see [[Special:Diff/1188825520/1201377710|diff]].
:step to test:
# visit [[Special:Contributions/2A02:C7F:745F:6400:69E1:8FB2:A675:2199]]
# hovering on "hist" of "100%" page
# expected message: "History preview failed :-("
:--[[User:Valepert|valepert]] ([[User talk:Valepert|talk]]) 22:57, 28 February 2024 (UTC)
::Implemented, thanks [[User:Valepert|valepert]]. However, two things of note: first, there are a ton more error messages that are not similarly isolated. Second, I notice there's an unrelated bug in your example, where the % in the article title display is being unnecessarily URI-encoded, which breaks the link to the article itself. [[User:Writ Keeper|Writ&nbsp;Keeper]]&nbsp;[[User Talk: Writ Keeper|&#9863;]][[Special:Contributions/Writ_Keeper|&#9812;]] 14:03, 29 February 2024 (UTC)

== Feature request: Show Block reason ==

Is it possible to add the most recent block log entry (for currently blocked users) into the popup? Similar to how [[MediaWiki:Gadget-markblocked.js]] puts the reason in the tooltip. I have both scripts enabled, and it does strikethrough the username but Popups overrides the markblocked tooltip for blocked editors so I can't see the block reason without navigating away from the page I'm on to check the block log. I'd try building it myself based on the markblocked gadget, but my Javascript knowledge is very limited. <span style="font-family:Papyrus, Courier New">[[User:The Wordsmith|'''The Wordsmith''']]</span><sup><span style="font-family:Papyrus"><small>''[[User talk:The Wordsmith|Talk to me]]''</small></span></sup> 21:11, 28 February 2024 (UTC)

== Certain user permissions (extended confirmed, global renamer) not showing ==

Usually when you hover over a username, popups shows all their local permissions in regular text, and all their global permissions in italics. However, I've noticed a couple permissions are not showing up. In particular, extended confirmed (local) and global renamer (global). I propose fixing these two, and doing an audit to make sure there's not any other permissions being missed. If there's some hard-coded list in the code somewhere, I propose switching to something that is not hard-coded so that new permissions can be reliably detected without code modifcations. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 04:13, 16 April 2024 (UTC)

:I believe extendedconfirmed is an intentional omission. (No opinion in whether it should be.) [[m:Global renamer|Global renamer]] is, technically speaking, a local right on Meta, not a global right. See e.g. [[Special:CentralAuth/Tamzin]]. As a global renamer, I'd definitely find it useful to have that included here, but I'd think it'd require an extra API call just for that check? <span style="font-family:courier"> -- [[User:Tamzin|<span style="color:#E6007A">Tamzin</span>]]</span><sup class="nowrap">&#91;[[User talk:Tamzin|<i style="color:#E6007A">cetacean needed</i>]]&#93;</sup> <small>([[User:Tamzin/🤷|they&#124;xe]])</small> 04:21, 16 April 2024 (UTC)
::Yeah, looks like global renamer is local to meta and would require its own API call. Good find, thank you. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 04:36, 16 April 2024 (UTC)
:::There could be a case for a no-permissions global group for global renamers, similar to VRT permissions agents, but I guess that would be a matter for Meta. <span style="font-family:courier"> -- [[User:Tamzin|<span style="color:#E6007A">Tamzin</span>]]</span><sup class="nowrap">&#91;[[User talk:Tamzin|<i style="color:#E6007A">cetacean needed</i>]]&#93;</sup> <small>([[User:Tamzin/🤷|they&#124;xe]])</small> 04:38, 16 April 2024 (UTC)
::"I believe extendedconfirmed is an intentional omission." correct. there are several groups (not permissions btw) that are filtered out because almost everyone has them. —[[User:TheDJ|Th<span style="color: green">e</span>DJ]] ([[User talk:TheDJ|talk]] • [[Special:Contributions/TheDJ|contribs]]) 08:22, 16 April 2024 (UTC)

== eslint-config-wikimedia autofixes ==

In a sandbox, I ran the official [https://github.com/wikimedia/eslint-config-wikimedia wikimedia javascript linter] on the popups code. [https://en.wikipedia.org/enwiki/w/index.php?title=User%3ANovem_Linguae%2FScripts%2Fpopups.js&diff=1220671324&oldid=1220670020 Here's the diff.]

* ran eslint-config-wikimedia autofixes
** <code>extends { "wikimedia/client/es6", "wikimedia/jquery", "wikimedia/mediawiki" }</code>
** excluding
*** controversial ones such as space-in-parens and max-len
*** no-var (changing var to let/const). this would be fine to do since Grade A support is on ES6 now, but will save for a future patch
*** unicorn/prefer-string-slice. I'm not sure the suggested <code>.slice( 0, Math.max(</code> is more readable/better than the existing <code>.substring(</code>
*** some rules that weren't auto-fixing well when I manually reviewed the code
** including rules such as comma-dangle, no-unneeded-ternary, no-useless-concat, operator-linebreak, semi-style, unicorn/prefer-date-now, dot-notation, jsdoc/check-tag-names, jsdoc/check-types, and others
* removed some comments

Will self-merge in a couple days if no objections.

Note to self: Manually test a bit on testwiki before deploying. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 06:36, 25 April 2024 (UTC)

:I really dislike the <code>[https://eslint.org/docs/latest/rules/comma-dangle "comma-dangle"]: "never"</code> setting, it makes subsequent diffs less readable (and accounts for a large part of the current diff as well). Could you change it to <code>only-multiline</code> (or <code>always-multiline</code> if you prefer) and revert your changes that removed trailing commas? Thanks in advance!
:Also, I don’t see any reference to this ESLint rule set in the code. Could you add a comment (even if not machine-readable) that informs future maintainers what they should lint the code with? —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 19:41, 26 April 2024 (UTC)
::Thanks for the feedback. I'll avoid comma-dangle for now. Although it's in the official Wikimedia JavaScript linter, so I'm sure they have their reasons.
::It'd be a pretty big comment, so I will probably have to keep it out of the code for now. The file I am using is...
::<syntaxhighlight lang="json">{
	"extends": [
		"wikimedia/client/es6",
		"wikimedia/jquery",
		"wikimedia/mediawiki"
	],
	"globals": {
		"mw": "readonly"
	},
	"parserOptions": {
		"ecmaVersion": "latest",
		"sourceType": "module"
	},
	"rules": {
		"camelcase": "off",
		"es-x/no-array-prototype-includes": "off",
		"es-x/no-async-functions": "off",
		"es-x/no-class-fields": "off",
		"es-x/no-optional-catch-binding": "off",
		"es-x/no-regexp-lookbehind-assertions": "off",
		"es-x/no-regexp-s-flag": "off",
		"es-x/no-rest-spread-properties": "off",
		"es-x/no-string-prototype-matchall": "off",
		"es-x/no-string-prototype-replaceall": "off",
		"jsdoc/require-param": "off",
		"jsdoc/require-param-type": "off",
		"jsdoc/require-returns": "off",
		"max-len": "off",
		"mediawiki/class-doc": "off",
		"no-jquery/no-class-state": "off",
		"no-jquery/no-global-selector": "off",
		"no-jquery/no-parse-html-literal": "off",
		"no-jquery/variable-pattern": "off",
		"no-shadow": "off",
		"no-underscore-dangle": "off",
		"security/detect-non-literal-regexp": "off",
		"security/detect-unsafe-regex": "off",
		"unicorn/prefer-string-slice": "off",
		"space-in-parens": "off",
		"computed-property-spacing": "off",
		"eqeqeq": "off",
		"no-var": "off",
		"spaced-comment": "off",
		"array-bracket-spacing": "off",
		"jsdoc/no-multi-asterisks": "off",
		"no-alert": "off",
		"no-tabs": "off",
		"jsdoc/require-asterisk-prefix": "off",
		"jsdoc/check-alignment": "off"
	}
}</syntaxhighlight> –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 13:14, 4 May 2024 (UTC)
:::{{Done}}. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 15:14, 4 May 2024 (UTC)
::::{{reply to|Novem Linguae}} Thanks for excluding <code>comma-dangle</code>!
::::<blockquote>Although it's in the official Wikimedia JavaScript linter, so I'm sure they have their reasons.</blockquote>
::::I guess simply legacy. According to [[ECMAScript version history#5th Edition – ECMAScript 2009]], a trailing comma in object literals is accepted only since ES5, and Wikipedia used to support ES3.
::::<blockquote>It'd be a pretty big comment, so I will probably have to keep it out of the code for now.</blockquote>
::::I see. Then maybe a subpage or a collapsible box on the top of this talk page? I fear a random talk page topic will get lost in the archives.
::::(Sorry for the late reply, I missed notifications due to a bot archival, which stopped watchlist emails despite not sending one itself.) —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 10:32, 18 May 2024 (UTC)
:::::I was reading a random Phab ticket today and found out why comma-dangle is in eslint-config-wikimedia. It's for easier copy-pasting to JSON. I guess this use case was important to Wikimedia developers back when they decided on this rule. Today I learned. –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 15:53, 1 June 2024 (UTC)
::::::What is that random Phab task? I find this hard to believe (or at least not well thought through) because at the same time we have <code>"[https://eslint.org/docs/latest/rules/quotes quotes]": "single"</code>, which is exactly the non-JSON-compatible version, and it’s even much more work to replace all the single quotes with double ones than deleting some commas. —[[User:Tacsipacsi|Tacsipacsi]] ([[User talk:Tacsipacsi|talk]]) 21:47, 1 June 2024 (UTC)
:::::::[[phab:T222707#5164890]] and [[phab:T222707#5165095]]
:::::::{{tq|(the developer community has had this conversation before and decided that easier portability to JSON is more important than cleaner diffs)}} –[[User:Novem Linguae|<span style="color:blue">'''Novem Linguae'''</span>]] <small>([[User talk:Novem Linguae|talk]])</small> 00:08, 2 June 2024 (UTC)

== Updates for dark mode ==

{{edit request|MediaWiki:Gadget-navpop.css|answered=yes}}
Can an interface admin please copy [[User:The wub/popups sandbox.css]] to [[MediaWiki:Gadget-navpop.css]] ([https://en.wikipedia.org/enwiki/w/index.php?title=User:The_wub/popups_sandbox.css&diff=1225802251&oldid=1167000423 comparison]). This updates the styling to work in the new dark mode ([[phab:T365749]]), following the guidance at [[mw:Recommendations for night mode compatibility on Wikimedia wikis]]. [[User:the wub|the wub]] [[User_talk:The wub|<span style="color: #080;">"?!"</span>]] 20:32, 26 May 2024 (UTC)
: {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:55, 27 May 2024 (UTC)
::Thanks very much! [[User:the wub|the wub]] [[User_talk:The wub|<span style="color: #080;">"?!"</span>]] 09:07, 27 May 2024 (UTC)
{{edit request|MediaWiki:Gadget-navpop.css|answered=yes}}
:::@[[User:Pppery|Pppery]]: Another edit, sorry. It was [[Wikipedia:Village pump (technical)#New diff preview problem|reported]] that forcing the diff text color clashes with the "Blackskin" gadget. I figured out some new diff background colors for dark mode which work with the white text color, avoiding the issue with Blackskin and I think looking better on the whole. Can you update from my sandbox again please? Here's the [https://en.wikipedia.org/enwiki/w/index.php?diff=1225974005&oldid=1225844220 diff]. [[User:the wub|the wub]] [[User_talk:The wub|<span style="color: #080;">"?!"</span>]] 21:43, 27 May 2024 (UTC)
:::: {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:31, 28 May 2024 (UTC)