View source for Wikipedia:Bots/Requests for approval/Hazard-Bot 21

<noinclude>[[Category:Expired Wikipedia bot requests for approval|Hazard-Bot 21]]</noinclude><div class="boilerplate metadata" style="background-color:
#DEDACA; margin:2em 0 0 0; padding:0 10px 0 10px; border:1px solid #AAAAAA;">
:''The following discussion is an archived debate. <span style="color:red">'''Please do not modify it.'''</span> To request review of this BRFA, please start a new section at [[WT:BRFA]].'' The result of the discussion was [[File:Symbol neutral vote.svg|20px|alt=|link=]] '''Request Expired'''.<!-- from Template:Bot Top-->
==[[User:Hazard-Bot|Hazard-Bot 21]]==
{{Newbot|Hazard-Bot|21}}
<!-- ^^^ Ignore everything above this line ^^^ -->

<!-- Leave this alone -->
'''Operator:''' {{botop|Hazard-SJ}}

<!-- And leave this alone -->
'''Time filed:''' 01:33, Tuesday May 28, 2013 ([[UTC]])

<!-- Automatic: edits are not reviewed, except when issues arise -->
<!-- Supervised: all edits are reviewed soon after being made -->
<!-- Manual: all edits are reviewed before being made -->
'''Automatic, Supervised, or Manual:''' Automatic

<!-- Programming Language: The computer language that this bot will be written in. E.g. Python, Java, C, VB, AutoWikiBrowser. NOT English etc. -->
'''[[Programming language]](s):''' Python

<!-- Source code available: e.g. a link to the source code, "Standard pywikipedia"/"AWB"/etc. Be sure the bot account's password is not given out! -->
'''[[Source code]] available:''' [https://github.com/HazardSJ/English-Wikipedia/blob/master/citationstyle.py GitHub]

<!-- A SHORT bot function overview (max 2–3 lines); place the in-depth explanation in the "function details" section below-->
'''Function overview:''' Fixing citation style

<!-- Bot tasks require consensus in order to be approved. Please list any relevant discussions here to indicate consensus for the task. If such input is not necessary (for instance, a task that is duplicating or closely matching an existing bot) leave this blank-->
'''Links to relevant discussions (where appropriate):''' [[Wikipedia:Bot requests/Archive 54#links within title parameter|bot request]]

<!-- e.g. Continuous, daily, one time run, etc. -->
'''Edit period(s):''' Periodic

<!-- Should be a reasonable guess as to how many distinct pages you'll be editing. For open-ended tasks, estimate pages per some reasonable time period.-->
'''Estimated number of pages affected:''' thousands

<!-- Whether the bot skips articles and other pages with the {{bots}} template. If "no", please provide a reason in the Function details or Discussion.-->
'''[[Template:bots|Exclusion compliant]]''' ''(Yes/No)''''':''' Yes

<!-- For existing bots only-->
'''Already has a bot flag''' ''(Yes/No)''''':''' Yes

<!-- List full and complete function details here. Please be precise and explicit, describing all changes the bot would make. Bots cannot be approved for open-ended tasks, so ensure the details cover all cases. Consider making several BRFAs for tasks with large independent changes. Vague or incomplete details can delay the BRFA process. Straight-forward details and examples will speed up the approval. If you need to modify these details after a discussion starts, it is recommended that you use del tags – <del></del> – to remove text and ins tags – <ins></ins> – for additions (this preserves coherence of the discussion), or show/hide boxes as you see fit. -->
'''Function details:''' Currently, it only fixes [[Help:CS1_errors#Wikilink_embedded_in_URL_title]], but I might implement more fixes as well (would separate approval be required in that case, since it's still fixing CS1 errors?). <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 01:33, 28 May 2013 (UTC)

===Discussion===
<!-- This is not a vote.  It is a discussion -->
* <code>self.removeWikilinks()</code> ...simply beautiful, my friend. Pywikipedia strikes again! :) On a related note, [[Wikipedia:Bots/Requests_for_approval/Theo%27s_Little_Bot_13|task 13]] on my bot also deals with a CS1 error. '''[[User:Theopolisme|<span style="color:#232323;">Theopolisme</span>]] <span style="color:#4F4F4F;">([[User talk:Theopolisme|<span style="color:#4F4F4F;">talk</span>]])</span>''' 01:41, 28 May 2013 (UTC)
** Yes, thanks :) Also, I believe I remember seeing that task, and I'm currently considering implementation of [[Help:CS1_errors#.7Carchiveurl.3D_requires_.7Carchivedate.3D]]. In such a case, It might be also useful to add your task to it as well ;) <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:44, 28 May 2013 (UTC)
* '''Questions'''
::# Does it fix parameters in {{tl|citation}}, or only those that start with "cite" or "web"? (noob question based on line 52)
::# Does it fix parameters that contain templates (e.g. {{diff|Aka Hoegh|prev|557038469|this edit}}), or should that be done in a separate bot task?
:Thanks!  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 01:58, 28 May 2013 (UTC)
** Answers:
**:# With that version of the code, only those starting with either "cite" or "web". I've just added support for {{tl|citation}} as well in [https://github.com/HazardSJ/English-Wikipedia/commit/7c12d355ed17fb75e53bd9126510ca61912c2585 this change], though I plan on coming up with a better and more specific list soon.
**:# As of [https://github.com/HazardSJ/English-Wikipedia/commit/51c1668ff752810e67d1bc3fe44b6b6367e3c099 this change], it should remove templates as well. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:44, 28 May 2013 (UTC)
**: You're welcome, and thanks for the code review ;) <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:44, 28 May 2013 (UTC)
:{{BotTrial|edits=50}} '''[[User:Addshore|<span style="color:black">·Add§hore·</span>]]''' <sup>[[User_talk:Addshore|<span style="color:black;">Talk To Me!</span>]]</sup> 08:33, 28 May 2013 (UTC)
::{{BotTrialComplete}} with [//en.wikipedia.org/enwiki/w/index.php?title=Special:Contributions/Hazard-Bot&offset=20130529002700&limit=52&target=Hazard-Bot 52 edits]. Also, would I need separate approvals per what I mentioned above? <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 00:29, 29 May 2013 (UTC)
:::I don't know if it requires separate approvals or not, but if it is all the same type of errors, couldn't you just trial an assortment of errors, BAG folk? -[[Special:Contributions/68.107.136.227|68.107.136.227]] ([[User talk:68.107.136.227|talk]]) 03:13, 29 May 2013 (UTC)
:Seems useful, catches an error, although the explanation template is too much to read. -[[Special:Contributions/68.107.136.227|68.107.136.227]] ([[User talk:68.107.136.227|talk]]) 22:43, 28 May 2013 (UTC)

These are surely not a good idea: [http://en.wikipedia.org/enwiki/w/index.php?title=Alexandrov_topology&diff=prev&oldid=557256799] [http://en.wikipedia.org/enwiki/w/index.php?title=Alexander_Alekhine&diff=prev&oldid=557256711] [http://en.wikipedia.org/enwiki/w/index.php?title=Ahmed_Shafik&diff=prev&oldid=557256207]

This is also not ideal [http://en.wikipedia.org/enwiki/w/index.php?title=Al_Jouf_University&diff=prev&oldid=557256241], a better outcome would be to shift the subscription flag to the citation's via parameter, e.g.: {{cite web|title=SAUDI ARABIA,UNITED STATES : Saudi's Al Jouf University Chooses Cisco WebEx, Offered in the Kingdom in Partnership With STC, for E-Learning. |via=[[HighBeam Research]] |url=
http://www.highbeam.com/doc/1G1-256221683.html|publisher=[[Mena Report]]|accessdate=23 August 2012|date=12 May 2011}}

[[User:Dragons flight|Dragons flight]] ([[User talk:Dragons flight|talk]]) 03:51, 29 May 2013 (UTC)

:[//github.com/HazardSJ/English-Wikipedia/commit/1b18ce6db904ec6655b517959ec93f668f2a21dc This commit] fixes the subscription issue (and potentially others?). I'm still considering about the {{tl|lang}} issues. Should I just remove the template, but leave the value of {{para|2}} which is the text itself, or put the entire citation template in the {{tl|lang}} template (I think this is unwise)? Otherwise I'd probably have to either just skip those errors, or set {{para|2}} to a null value before the citation template, leaving the actual value in the citation template. What do you suggest? <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 07:02, 1 June 2013 (UTC)
::I suggest converting {{tl|lang}} to {{para|language}} and leaving the value of {{para|2}} in the {{para|title}} parameter (e.g. {{diff|Death_Magnetic|next|556513991|this edit}}), and then deleting any duplicated {{para|language}} parameter.  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 15:16, 1 June 2013 (UTC)
::I have an uncommitted fix for it, but I'm trying to work out [//en.wikipedia.org/enwiki/w/index.php?title=Alexandrov_topology&diff=557905433&oldid=557900529 this issue] (see [[bugzilla:2700|bug 2700]]). <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 01:24, 2 June 2013 (UTC)
::Fixed in [//github.com/HazardSJ/English-Wikipedia/commit/04e7f89af005d06f6648e259376bf63d777c4b73 this commit]. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:52, 2 June 2013 (UTC)
:::Is this ready for another trial? please {{tl|ping}} me with your response :) '''[[User:Addshore|<span style="color:black">·addshore·</span>]]''' <sup>[[User_talk:Addshore|<span style="color:black;">talk to me!</span>]]</sup> 09:12, 2 June 2013 (UTC)
::::{{Ping|Addshore}} No, I'm not yet ready, I'd like to improve the code and add a few more features first. I'll keep you updated. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 22:59, 3 June 2013 (UTC)
::::{{Ping|Addshore}} [//github.com/HazardSJ/English-Wikipedia/commit/8600350a784904e292fe7dcd8dfdf56d106cc96e (diff)] I added some more features and did some code clean-up, so I think I'm ready again. As a side note, [//en.wikipedia.org/enwiki/w/index.php?title=Special:Contributions/Hazard-Bot&offset=20130606004042&limit=31&target=Hazard-Bot these edits] were accidentally made, though with an outdated version of the code. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:36, 7 June 2013 (UTC)
::::::{{BotTrial|edits=50}} '''[[User:Addshore|<span style="color:black">·addshore·</span>]]''' <sup>[[User_talk:Addshore|<span style="color:black;">talk to me!</span>]]</sup> 08:17, 7 June 2013 (UTC)
{{od}} {{BotTrialComplete}} ([//en.wikipedia.org/wiki/Special:Contributions/Hazard-Bot?offset=20130611041500&limit=55 edits]) <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 04:20, 11 June 2013 (UTC)
:* Edits such as {{diff|1920_Columbus_Panhandles_season|next|488290170|this one}} and {{diff|1920_Hammond_Pros_season|prev|559335517|this one}} look a bit odd.  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 04:36, 11 June 2013 (UTC)

* [http://en.wikipedia.org/enwiki/w/index.php?title=Template_talk:Citation/core/Archive_4&diff=prev&oldid=559336577] [http://en.wikipedia.org/enwiki/w/index.php?title=Template_talk:Citation/core/Archive_4&diff=prev&oldid=559336577] [http://en.wikipedia.org/enwiki/w/index.php?title=Template_talk:Cite_news/Archive_5&diff=prev&oldid=559336682] etc.
* (Don't see this task explicitly listed, but I see you mention it in the discussion, so posting here) I strongly suggest you limit the automatic edits to article space, to avoid edits like [http://en.wikipedia.org/enwiki/w/index.php?title=Wikipedia:Bots/Requests_for_approval/H3llBot_6&curid=32007543&diff=559336202&oldid=433218293 this]. We generally treat all bots as article-only, unless otherwise stated. In this case, it is not uncommon to have wrong citation style as examples or problem tests, and the bot should not assume other namespaces require automatic correction. —&nbsp;<small>&nbsp;[[user:Hellknowz|<span style="color:#B00;">HELL</span>KNOWZ]]&nbsp;&nbsp;▎[[User talk:Hellknowz|TALK]]</small> 07:37, 11 June 2013 (UTC)
** [//github.com/HazardSJ/enwiki/commit/e28e21eacd09159346156aaa89fd1d25e4f951b2 Fixed] <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 03:46, 16 June 2013 (UTC)
:{{BotTrial|edits=50}} '''[[User:Addshore|<span style="color:black">·addshore·</span>]]''' <sup>[[User_talk:Addshore|<span style="color:black;">talk to me!</span>]]</sup> 18:46, 16 June 2013 (UTC)
::Hazard, I'm not a pywikipedia expert and don't pretend to be, but doesn't <code>page.namespace()</code> just return the namespace number? I bet I'm just missing something, but an explanation'd be great. Thanks! '''[[User:Theopolisme|<span style="color:#232323;">Theopolisme</span>]] <span style="color:#4F4F4F;">([[User talk:Theopolisme|<span style="color:#4F4F4F;">talk</span>]])</span>''' 04:35, 17 June 2013 (UTC)
::: You're correct about it returning the namespace number, but remember that <code>if 0</code> in Python returns False, and other digits return True, so in other words, if the namespace number is not zero, it continues to the next page. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 05:54, 18 June 2013 (UTC)
::::'''*headdesk*''', duh :p '''[[User:Theopolisme|<span style="color:#232323;">Theopolisme</span>]] <span style="color:#4F4F4F;">([[User talk:Theopolisme|<span style="color:#4F4F4F;">talk</span>]])</span>''' 14:18, 18 June 2013 (UTC)
::::: {{BotTrialComplete}} ([//en.wikipedia.org/wiki/Special:Contributions/Hazard-Bot?limit=49&offset=20130622171000 edits]); I haven't checked them all as yet (it somehow only did 49, though), but an obvious problem so far is the comments being copied from archiveurl the url where present. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 17:14, 22 June 2013 (UTC)
::::::I only checked half the edits.  Some of these edits may be garbage in, garbage out, but they look strange:
::::::*In {{diff|Brothers_Stoney|prev|561085184|this edit}} and {{diff|Ernie_Althoff|prev|561085869|this edit}}, I wouldn't expect {{tl|citation needed}} within {{tag|ref}}.
::::::*In {{diff|Comparison_of_HTML5_and_Flash&diff=prev&oldid=561085317|this edit}} and {{diff|Content_(media)|prev|561085495|this edit}}, the URLs were already in the {{para|deadurl}} parameter.
::::::*{{diff|Follia_d'amore|prev|561085979|This edit}} moved <nowiki>{{!}}</nowiki> from the {{para|title}} parameter to the end of the reference. <small><span class="autosigned">— Preceding [[Wikipedia:Signatures|unsigned]] comment added by [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]] • [[Special:Contributions/GoingBatty|contribs]]) 03:21, 23 June 2013 (UTC)</span></small><!-- Template:Unsigned -->
:::::::I have raised [[User talk:Hazard-SJ#Bad bot edit|similar concerns on your talk page]] and [//en.wikipedia.org/enwiki/w/index.php?title=User:Hazard-Bot/DoTask/21&diff=561209352&oldid=557255710 disabled the task] for good measure. '''[[User:Graham87|Graham]]'''[[User talk:Graham87|<span style="color:green;">87</span>]] 14:13, 23 June 2013 (UTC)

The ongoing errors are a bit of a worry for me, especially as this bot is running in the article space. I'm leaning towards denying this task. --[[User_talk:Chris G|<span style="color:Green; font-weight: bold;">Chris</span>]] 13:20, 24 June 2013 (UTC)
:I will leave out the part of the code that moves templates out of citation templates (maybe the language replacements are okay, since that's specifically hard-coded?). Also, I can code the bot to not make replacements in ref tags (as I did on a recently approved task). Also, I will have it check for {{para|deadurl}} as well. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:41, 25 June 2013 (UTC)
::{{tl|BAGAssistanceNeeded}} In response too what I've said, [//github.com/HazardSJ/enwiki/commit/0c8bf814b0663cbc00cce52a9a286adec4ab5218 may I have another trial please]? <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 00:35, 3 July 2013 (UTC)
:{{BotTrial|edits=50}} '''[[User:Addshore|<span style="color:black">·addshore·</span>]]''' <sup>[[User_talk:Addshore|<span style="color:black;">talk to me!</span>]]</sup> 12:01, 21 July 2013 (UTC)
::Started, only did [https://en.wikipedia.org/wiki/Special:Contributions/Hazard-Bot?offset=20130824043600&limit=12 these] so far, I'll try to finish when I get back online. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 04:02, 24 August 2013 (UTC)
:::In {{diff|Woman_(Wolfmother_song)|prev|569946564|this edit}}, the bot added {{para|archivedate|02 March 2012}} - the leading zero is not needed.  It would also be nice (but too much to ask for?) if the bot could have detected that the reference already had an archivedate and was just missing the pipe.  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 14:07, 24 August 2013 (UTC)
:::: [https://github.com/HazardSJ/enwiki/commit/a82e2bdc03497c381bfbbf3eeee3c031cf52a41e This change] should strip the leading "0" if available. Also, as for the pipe issue, there might be (hopefully) few of such cases, and though I'm not sure if all such mistakes would all be in the same format, but if it's a frequent issue I could get a pattern to attempt it (running from false positives here). <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 02:45, 25 August 2013 (UTC)
:::::I thought this task was about removing links and templates from citation templates, but these edits are fixing archive link errors...''':Jay8g''' <small>[<nowiki />[[User:Jay8g|V]]•[[User talk:Jay8g|T]]•[[Special:Contributions/Jay8g|E]]<nowiki />]</small> 18:07, 25 August 2013 (UTC)
::::::This task focuses on errors related to citation templates, which include the archive links. As for the templates, it's better to have that part more specific (hard-code for certain templates only, because, as seen from the above, can cause many problems). IIRC, there isn't a problem with links. However, thanks for the mention, it caused me to look back at the code and notice that I disabled the entire link/template section rather than just that part that isn't specific as it pertains to templates (which, as I said, can be very troublesome). [//github.com/HazardSJ/enwiki/commit/c39f0004605a53fe5fc3bc60a34fdf54ac259d9b That has now been fixed in the code]. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 05:15, 28 August 2013 (UTC)
{{od}} I'll also be adding [//en.wikipedia.org/enwiki/w/index.php?title=Wikipedia:Bot_requests&oldid=570496002#Category:Pages_using_citations_with_accessdate_and_no_URL this], and as I mentioned before, possibly others in the future. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 06:07, 28 August 2013 (UTC)
: OK, [//github.com/HazardSJ/enwiki/commit/3755e84dfcf56716d60370fd2e6cde61e6d1a344 here it is]. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 06:25, 28 August 2013 (UTC)
:: I just resumed the trial, and from the above code, got [//en.wikipedia.org/wiki/Special:Contributions/Hazard-Bot?limit=15&offset=20130828062828 these]. I however, stopped the trial to disable that part for now, so I can get some of the other parts involved. <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 06:30, 28 August 2013 (UTC)
::: {{BotTrialComplete}} OK, continuing from above, I resumed with a trial that actually made [//en.wikipedia.org/wiki/Special:Contributions/Hazard-Bot?limit=49&offset=20130828071314 49 more edits]. It would have actually been 50, had the attempt to edit [[Georgia O'Keeffe]] actually been successful. The attempt was:
::: <code><nowiki>- On January 10, 1977, [[President of the United States|President]] [[Gerald R. Ford]] presented O'Keeffe with the [[Presidential Medal of Freedom]], the highest honor awarded to American citizens.<ref>{{cite web |archiveurl=http://web.archive.org/web/20071024122700/http://www.medaloffreedom.com/GeorgiaOKeefe.htm |title=Georgia O'Keeffe|archivedate=October 24, 2008 |accessdate=June 1, 2010}}</ref> In 1985, she was awarded the [[National Medal of Arts]].</nowiki></code>
::: <code><nowiki>+ On January 10, 1977, [[President of the United States|President]] [[Gerald R. Ford]] presented O'Keeffe with the [[Presidential Medal of Freedom]], the highest honor awarded to American citizens.<ref>{{cite web |archiveurl=http://web.archive.org/web/20071024122700/http://www.medaloffreedom.com/GeorgiaOKeefe.htm |title=Georgia O'Keeffe|archivedate=October 24, 2008 |accessdate=June 1, 2010|url=http://www.medaloffreedom.com/GeorgiaOKeefe.htm}}</ref> In 1985, she was awarded the [[National Medal of Arts]].</nowiki></code>
::: which, according to my checks, failed because of a spam filter for ''medaloffreedom.com'' on [[MediaWiki:Spam-blacklist]].
::: Error-wise, I picked up things like [//en.wikipedia.org/enwiki/w/index.php?title=Grave_of_the_Fireflies_%282005_film%29&diff=prev&oldid=570499977], [//en.wikipedia.org/enwiki/w/index.php?title=FMetro&diff=prev&oldid=570499540], [//en.wikipedia.org/enwiki/w/index.php?title=Gaoqiao,_Kai_County&diff=prev&oldid=570499696], and [//en.wikipedia.org/enwiki/w/index.php?title=Der_K%C3%B6nig_Kandaules&diff=prev&oldid=570498803], all of which are as a result of the bot not having a record of those language codes (well, at least one of them was invalid), and [//en.wikipedia.org/enwiki/w/index.php?title=Dutch_East_Indies&diff=prev&oldid=570498980 this], which the bot wouldn't have been able to correctly fix. As for the first issue, I'll simply fix it by, firstly, updating the list of languages it's aware of, and secondly, to avoid repetition of this, the bot will no longer add <code><nowiki>{{#language:xx|en}}</nowiki></code>, but rather, either leave the {{tl|lang}} template or remove it there's already a language parameter set. I hope this request is more promising now. Thanks, <b><span style="border:2px solid;font-variant:small-caps">[[User:Hazard-SJ|<span style="background:#00008B;color:#FFF">&nbsp;Hazard-SJ&nbsp;</span>]][[User talk:Hazard-SJ|<span style="color:#00008B;background:red">&nbsp;✈&nbsp;</span>]]</span></b> 07:39, 28 August 2013 (UTC)

==== Language ====
{{ping|GoingBatty}} {{tl|lang}} and {{para|language}} do different things. Please read up on the former, which should not be removed without thought. {{ping|Hazard-SJ}} this page is difficult to read because of your garish sig. Please tone it down. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 19:58, 28 August 2013 (UTC)
:{{ping|Pigsonthewing}} - [[Template:Lang]] states "This template also includes a categorisation link when used by main namespace pages, therefore it should not be included inside a wikilink."  Since the {{para|title}} parameter of {{tl|cite web}} contains a wikilink, using the {{tl|lang}} template within the {{para|title}} causes a visible categorisation error in the reference: see [[Compagnie des Transports Strasbourgeois]] for an example.  Your thoughts on the best way to fix these errors would be appreciated.  Thanks!  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 23:28, 28 August 2013 (UTC)
:: Correct. <span style="background:#008;border:2px solid #000;font-variant:small-caps">&nbsp;[[User:Hazard-SJ|<b style="color:#FFF">Hazard</b>]]&nbsp;[[User talk:Hazard-SJ|<b style="color:#FFF">SJ</b>]]&nbsp;</span> 08:17, 29 August 2013 (UTC)
::{{ping|GoingBatty}} Good: <nowiki>{{lang|fr|[[Zut alors!]]}}. Bad: [[{{lang|fr|Zut alors!}}]]</nowiki>. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 10:16, 29 August 2013 (UTC)
:::{{ping|Pigsonthewing}} - Also Bad: <code><nowiki><ref>{{cite web|url=http://www.zutalors.fr|title={{lang|fr|Zut alors!}}}}</ref></nowiki></code> <small><span class="autosigned">—&nbsp;Preceding [[Wikipedia:Signatures|unsigned]] comment added by [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]] • [[Special:Contributions/GoingBatty|contribs]]) 17:20, 29 August 2013‎</span></small><!-- Template:Unsigned -->
::::{{ping|GoingBatty}} How else do you suggest that we mark up the titles of non-English works, such that the emitted HTML complies with HTML and WCAG standards? (And where would be a better place to discuss this issue; which is probably drifting from relevance here?) <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 22:30, 29 August 2013 (UTC)
::::: {{Ping|Pigsonthewing}} What exactly is your issue with {{para|language}}? <span style="background:#008;border:2px solid #000;font-variant:small-caps">&nbsp;[[User:Hazard-SJ|<b style="color:#FFF">Hazard</b>]]&nbsp;[[User talk:Hazard-SJ|<b style="color:#FFF">SJ</b>]]&nbsp;</span> 02:18, 30 August 2013 (UTC
::::::{{Ping|Hazard-SJ}} None whatsoever. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 16:29, 30 August 2013 (UTC)
::::: {{Ping|Pigsonthewing}} - I was suggesting that this bot be coded so it would change my example above to <code><nowiki><ref>{{cite web|url=http://www.zutalors.fr|title=Zut alors!|language=French}}</ref></nowiki></code>.  If Hazard-SJ doesn't want to include that in the scope of this bot, then I agree we should stop discussing it here.  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 16:48, 31 August 2013 (UTC)
::::::{{ping|GoingBatty}} Yes; and my point is that that contains nothing that indicates tat the phrase "Zut alors!" is not English. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 17:10, 31 August 2013 (UTC)
:::::::{{Ping|Pigsonthewing}} - The {{para|language}} parameter indicates that the reference text (and therefore probably the title too) are not English.  I'm open to alternate suggestions that do not produce errors.  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 17:40, 31 August 2013 (UTC)
::::::::{{ping|GoingBatty}} The use of {{para|language}} may suggest a ''probability'' that the title is in another language, but it does not guarantee it; and it does not indicate it in the emitted HTML, as does {{tl|lang}}, though the use of the appropriate HTML attribute, as described in the latter's documentation, to which I referred  you earlier. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 17:58, 31 August 2013 (UTC)
:::::::::{{Ping|Pigsonthewing}} - Could you please provide an alternate suggestion for Hazard-SJ for removing the errors generated by using {{tl|lang}} in the {{para|title}} parameter?  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 18:17, 31 August 2013 (UTC)
::::::::::{{ping|GoingBatty}} What errors? <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 17:21, 1 September 2013 (UTC)
:::::::::::{{Ping|Pigsonthewing}} - Sorry I haven't been able to explain this properly, so let me try again.  Up above on June 1, I provided {{diff|Death_Magnetic|next|556513991|this edit}}, which fixed the <span style="color:red;">Wikilink embedded in URL title</span> error on {{oldid|Death Magnetic|557841413|reference 140 on the Death Magnetic article}}.  Similarly, {{diff|Compagnie_des_Transports_Strasbourgeois|570924159|570498532|this edit}} by another editor fixed similar errors on {{oldid|Compagnie des Transports Strasbourgeois|570924159|references 21 and 42 on the Compagnie des Transports Strasbourgeois article}}.  Both of these examples demonstrate that using {{tl|lang}} in the {{para|title}} parameter of a citation template produces a visible error and categorizes the article in [[:Category:Pages with citations having wikilinks embedded in URL titles]], and that my suggestion to Hazard-SJ for fixing them is to remove {{tl|lang}} and use {{para|language}} instead.  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 00:30, 2 September 2013 (UTC)

{{od}}
{{ping|GoingBatty}} Thank you; I wasn't aware of you having attempted an explanation previously. {{tl|lang}} does not emit or cause to be emitted a link in the text which it contains; the issue appears to be the emitted category. The solution would therefore seem to be one of: ask for that template to not emit a category when used in a reference; change the way in which it emits a category;have a sister template for use in references, which dos not emit a category; or have the functionality embedded in the citation template core itself. the later is probably the most elegant solution. As I said above, {{para|language}} does not have the same functionality as {{tl|lang}} and is not a workable alternative to it. <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 10:07, 2 September 2013 (UTC)
:P.S. In the interim, the template could be commented out, allowing its later reinstatement., <span class="vcard"><span class="fn">[[User:Pigsonthewing|Andy Mabbett]]</span> (<span class="nickname">Pigsonthewing</span>); [[User talk:Pigsonthewing|Talk to Andy]]; [[Special:Contributions/Pigsonthewing|Andy's edits]]</span> 11:08, 2 September 2013 (UTC)

I seem to have missed out a lot here, but to put it simply, my bot has already had that feature for some time now. The current version works for both {{tl|lang}} and <nowiki>{{lang-xx}}</nowiki> style templates, as should be seen from the trials. In that case, if there's anything I missed, please let me know. <span style="background:#008;border:2px solid #000;font-variant:small-caps">&nbsp;[[User:Hazard-SJ|<b style="color:#FFF">Hazard</b>]]&nbsp;[[User talk:Hazard-SJ|<b style="color:#FFF">SJ</b>]]&nbsp;</span> 01:29, 3 September 2013 (UTC)

==== Experienced wikilink error remover offering help ====
I have fixed about 5,000 of the 8,000+ articles that were in [[:Category:Pages_with_citations_having_wikilinks_embedded_in_URL_titles]]. I have often thought about having a bot do the tasks, but they are so varied that it seems like less than 50% of them should be fixed by a bot. I'll be happy to have a discussion with you here or elsewhere about the fixes I have been making and the kinds of edge cases I have encountered. You can also look at my contribution history to see how I have handled any number of cases. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 14:33, 30 August 2013 (UTC)
:{{ping|Jonesey95}} - You've done great work cleaning up this category!  I hope the bot could fix the most common cases, but we'll still need passionate editors such as yourself to manually fix the edge cases.  Thanks!  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 18:21, 31 August 2013 (UTC)
: {{Ping|Jonesey95|GoingBatty}} My bot already supports removing wikilinks from in titles, but the category also lists those with templates in the titles (I believe, though I'm not sure), which is where an issue has been raised. I've therefore have to hard-code this to handle specific instances of this (currently supports {{tl|lang}} (see section above), and {{tl|subscription required}}), so the rest would need manual review, unless they are general simple cases, which I could also hard-code. As we've established from the earlier trials, I can't just remove random templates, because there are far too many false positives. <span style="background:#008;border:2px solid #000;font-variant:small-caps">&nbsp;[[User:Hazard-SJ|<b style="color:#FFF">Hazard</b>]]&nbsp;[[User talk:Hazard-SJ|<b style="color:#FFF">SJ</b>]]&nbsp;</span> 01:37, 3 September 2013 (UTC)
::The templates that add articles to this category are those that generate wikilinks, either to articles, e.g. {{tl|sic}}, or to categories, e.g. {{tl|fr icon}} and {{tl|lang}} and {{tl|nihongo}}.  If you're interested in bot-fixable editing of these citations, here's my advice:
::*Unilaterally change {{tl|sic}} to an appropriate form that conforms to [[WP:MOS]], if there is one. I haven't looked. Maybe [sic] or ''[sic]''. 
::*Move {{tl|subscription required}} outside the cite template but before the closing <nowiki></ref></nowiki> tag. Make sure to put a space between the closing braces for the cite template and the opening braces for the subscription template.  
::*{{tl|lang}} can be dealt with by stripping the lang template from the title parameter (or commenting it out), but you need to make sure that there is an appropriate <nowiki>language=XXXXX</nowiki> (using the full name of the language) parameter in the citation. As described in the discussion above, there does not appear to be an error-free way to indicate "This title (as opposed to the publisher's name or the work's name) is in language X" without generating a Lua error. Maybe someone will modify the cite template to make that option available. 
::*{{tl|nihongo}} and {{tl|nihongo2}} should follow the same rule, except that the language is always Japanese. {{tl|nihongo}} and its ilk take multiple parameters separated by pipes, so they may not be bot-fixable. This template often requires the addition of the <nowiki>trans_title</nowiki> parameter to make it look right, and I don't think there is a general way for a bot to decide how to fix it in each case.  
::*When I find {{tl|XX icon}}, where XX is the two- or three-letter code for a language, I have been moving the template outside the cite template but before the closing <nowiki></ref></nowiki> tag. Make sure to put a space between the closing braces for the cite template and the opening braces for the XX icon template.  
:::*Note that many {{tl|XX icon}} templates have redirects of the form {{tl|XX}}, such as {{tl|fr}} for {{tl|fr icon}}. Not all two-letter versions of this template are redirects to the {{tl|XX icon}} template, however.
:::*Another note: for some reason, most articles that use {{tl|ru icon}} have the incorrect parameter value <nowiki>language=ru</nowiki> instead of <nowiki>language=Russian</nowiki>. If your bot wants to fix those, that would be great.
::*There are other templates that cause problems, but I don't think they are bot-fixable. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 19:19, 3 September 2013 (UTC)
::::If you want your bot to handle some or all of these situations, here are some options:
:::::*For {{tl|sic}}, you could add {{para|nolink|y}} to suppress the wikilink.
:::::*You could change {{subscription required}} to {{para|subscription|y}}.
:::::*You could also change {{tl|XX icon}} to the appropriate {{para|language}} parameter.
::::Thanks!  [[User:GoingBatty|GoingBatty]] ([[User talk:GoingBatty|talk]]) 16:47, 4 September 2013 (UTC)
::::: Thanks. For {{tl|subscription required}} I've been switching them to {{para|via}}. <span style="background:#008;border:2px solid #000;font-variant:small-caps">&nbsp;[[User:Hazard-SJ|<b style="color:#FFF">Hazard</b>]]&nbsp;[[User talk:Hazard-SJ|<b style="color:#FFF">SJ</b>]]&nbsp;</span> 04:43, 5 September 2013 (UTC)

::::::For the {{cs1}} templates that have been converted to Lua ({{tlx|citation}}, {{tlx|cite AV media}}, {{tlx|cite book}}, {{tlx|cite conference}}, {{tlx|cite encyclopedia}}, {{tlx|cite journal}}, {{tlx|cite news}}, {{tlx|cite press release}}, {{tlx|cite sign}}, and {{tlx|cite web}}) a better solution to {{tlx|subscription required}} issues is to set the CS1 template parameter {{para|subscription|yes}}.  When {{tld|subscription required}} contains {{para|via}}, then also set the CS1 template's {{para|via}} parameter. <small><span class="autosigned">—&nbsp;Preceding [[Wikipedia:Signatures|unsigned]] comment added by [[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]] • [[Special:Contributions/Trappist the monk|contribs]]) 13:14, 5 September 2013‎</span></small><!-- Template:Unsigned -->

::::::The Lua based CS1 templates now support ISO639-1 codes in {{para|language}}.  This provides the same categorization as the {{tld|xx icon}} templates.

::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 10:00, 25 September 2013 (UTC)
{{tl|OperatorAssistanceNeeded|D}} There's been several improvements and extended trials.  Is there any outstanding issues left? [[User:Hasteur|Hasteur]] ([[User talk:Hasteur|talk]]) 01:12, 21 September 2013 (UTC)
: Well, with what is in mind from the last trial, with the fixes I said, that's basically it. There are probably one or two cases of the wikilink removal instances above I could hard-code as well, but, again, as far as I'm aware, that's about it. <span style="background:#008;border:2px solid #000;font-variant:small-caps">&nbsp;[[User:Hazard-SJ|<b style="color:#FFF">Hazard</b>]]&nbsp;[[User talk:Hazard-SJ|<b style="color:#FFF">SJ</b>]]&nbsp;</span> 03:16, 25 September 2013 (UTC)
::{{tl|OperatorAssistanceNeeded|D}}
::I read that response as: since the last trial there have been code changes. Is that right? [[User_talk:Josh Parris|Josh Parris]] 10:33, 5 November 2013 (UTC)

Operator has edited on four days in the last two months and has become unresponsive.  I'm expiring this without prejudice; the operator is welcome to re-open. {{BotExpired}} [[User_talk:Josh Parris|Josh Parris]] 07:40, 17 November 2013 (UTC)
:''The above discussion is preserved as an archive of the debate.  <span style="color:red">'''Please do not modify it.'''</span> To request review of this BRFA, please start a new section at [[WT:BRFA]].''<!-- from Template:Bot Bottom --></div>