User talk:Daduxing/familytree.js

New owner

See

• Wikipedia:Miscellany for deletion/User:GregU/familytree
• Wikipedia:Interface administrators' noticeboard/Archive 1#Undeletion request for Familytree.js
• User:Daduxing/familytree and User:Daduxing/familytree.js

OK User:Daduxing I have now read the above and understand why you asked me for help. I am typing this on a tablet, which is not ideal. I will have a look on a computer in the next 24 hours. In the mean time I am going to recover an old copy of the documentation and edit it. Please take a look at User:Daduxing/familytree and improve it (but give me an hour). PBS (talk) 16:47, 25 January 2020 (UTC)

No problem, take your time and thank you very much PBS for help.

I had a look at the code. It is more broken than I thought, as it does not seem to work for familytree templates. Do you know when it stopped working? -- PBS (talk) 16:29, 27 January 2020 (UTC)

I noticed when the Template:Chart was moved to Template:Tree chart because I suspected that it will not recognize the new naming, and verifying, I realized that I was right.
For me it is still working with the old Templates ( chart and familytree), but it is true that it always had a strange error (you could see the last message from this discussion User talk:Daduxing#Help!). --Daduxing (talk) 17:43, 27 January 2020 (UTC)

Can you either provide a link to a tree on which familytree.js still works, or provide a simple tree here. -- PBS (talk) 17:49, 27 January 2020 (UTC)

See my User:Daduxing/sandbox. Especially the first two trees. The first is a familytree and the second is a chart. They all work. You can test there if you like.--Daduxing (talk) 17:59, 27 January 2020 (UTC)

New and modified code

I think I have solved the specific problem of various names for chart and familytree templates. There is now a working version at User:PBS/familytree.js. To test it please implement the following steps.

1. edit User:Daduxing/vector.js
2. remove the line importScript("User:GregU/familytree.js"); -- it is redundant and confusing.
3. alter the line importScript("User:Daduxing/familytree.js"); to importScript("User:PBS/familytree.js");

and run tests. Please report any mistakes to me. Once you are satisfied with the changes then you can copy the code at User:PBS/familytree.js to User:Daduxing/familytree.js and then change the link back in User:Daduxing/vector.js to point to importScript("User:Daduxing/familytree.js"); -- PBS (talk) 11:20, 31 January 2020 (UTC)

Looks good. Thank you very much for fixing it. --Daduxing (talk) 14:42, 31 January 2020 (UTC)

Looking at your code today you need to change the line:

var Summary  = "Edited {{%s}} using [[User:PBS/familytree.js|familytree.js]]";

to:

var Summary  = "Edited {{%s}} using [[User:Daduxing/familytree.js|familytree.js]]";

This is a semi cosmetic change it just affects the summary-- PBS (talk) 16:15, 30 May 2020 (UTC)