Template talk:Done
Template:Done is permanently protected from editing because it is a heavily used or highly visible template. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit. Usually, any contributor may edit the template's documentation to add usage notes or categories.
Any contributor may edit the template's sandbox. Functionality of the template can be checked using test cases. |
Green check
The check was moved back to the green form, I agree with this. It should be probably discussed here first anyway as this is used a ton in FAC's. I think the green version is better. Quadzilla99 21:45, 15 March 2007 (UTC)
- I just changed it back to green let's discuss this. Quadzilla99 21:47, 15 March 2007 (UTC)
- I concur with Quadzilla, the green form is more visible. Just because the banner that denotes an official policy uses a check isn't a good reason to not use a green check elsewhere. It is highly unlikely that the two will ever be confused. —Disavian (talk/contribs) 21:48, 15 March 2007 (UTC)
- Policy is marked with this check. It is problematic to be liberally using it as it sets up confusion for newbies. See: Wikipedia:Attribution and notice how sections are marked. (→Netscott) 21:49, 15 March 2007 (UTC)
- Unless there have been several specific cases of confusion that can be cited I would say keep it green. Quadzilla99 21:51, 15 March 2007 (UTC)
- Please join the discussion on Wikipedia:Village pump (policy). Thanks. (→Netscott) 22:00, 15 March 2007 (UTC)
- Unless there have been several specific cases of confusion that can be cited I would say keep it green. Quadzilla99 21:51, 15 March 2007 (UTC)
- Policy is marked with this check. It is problematic to be liberally using it as it sets up confusion for newbies. See: Wikipedia:Attribution and notice how sections are marked. (→Netscott) 21:49, 15 March 2007 (UTC)
Any objection to making this substable?
Is there any? I just mean making it where there are no nested templates, so it can be more easily substed? - cohesion 01:37, 16 May 2007 (UTC)
Protection
This template should be semi-protected as it is used in many many places.--The Joke النكتة 14:43, 26 May 2007 (UTC)
- Bah, for now there never has been any vandalism here. Let's cross our fingers :) -- lucasbfr talk 21:24, 28 June 2007 (UTC)
- This should be semi-protected, it can be considered a high-risk template. I will apply for it. -- Reaper X 03:52, 6 July 2007 (UTC)
- Haha, its Done. I actually got it fully protected. -- Reaper X 07:58, 6 July 2007 (UTC)
- This should be semi-protected, it can be considered a high-risk template. I will apply for it. -- Reaper X 03:52, 6 July 2007 (UTC)
Too large
The image on the green check mark is larger than the text font and distorts text wherever it's used: can the image size be reduced? SandyGeorgia (Talk) 00:27, 31 July 2007 (UTC)
- Changing {{tick}} to {{tick]10}} would eliminate the distortion of the surrounding text; these things are cluttering documents all over WP:FAC. SandyGeorgia (Talk) 00:33, 31 July 2007 (UTC)
- Done – Luna Santin (talk) 03:17, 31 July 2007 (UTC)
- Thanks ! SandyGeorgia (Talk) 03:24, 31 July 2007 (UTC)
- Done – Luna Santin (talk) 03:17, 31 July 2007 (UTC)
I don't see the point of the template if the tick is so small it can barely be seen. We don't need to illustrate "done", it seems to me we use a large symbol so its prominent and informative. At that size people may as well use '''done''' instead. The template is used in a lot of places where requests are made of admins and bureaucrats so the outcomes are clear on a quick scan of the page - it does that in the first example but no longer really does in the second:
- Done
- Done
- Done
I don't see what the second example achieves that the third would not. I propose the template be reverted to the larger size and where it causes display problems it be replaced with '''Done'''. WjBscribe 09:13, 31 July 2007 (UTC)
- I agree with this. I've made the image bigger but not quite as big as it was previously. violet/riga (t) 09:24, 31 July 2007 (UTC)
- Thanks for the feedback; WJB, the point that you're making is exactly the point I've been making at WP:FAC. Rather than cluttering FACs with numerous green check marks throughout the FAC, the nominator could use half as many keystrokes to just type the word Done. This template probably serves a purpose elsewhere; the way it's being used as FAC is creating messy pages. SandyGeorgia (Talk) 09:36, 31 July 2007 (UTC)
- If used properly in FAC the template can be useful to both nominator and commenter. There are some places where it has been used confusingly and messily though, and I understand what you are saying. violet/riga (t) 09:40, 31 July 2007 (UTC)
- Well, at least the current size is better; thanks all for the help. SandyGeorgia (Talk) 10:28, 31 July 2007 (UTC)
- If used properly in FAC the template can be useful to both nominator and commenter. There are some places where it has been used confusingly and messily though, and I understand what you are saying. violet/riga (t) 09:40, 31 July 2007 (UTC)
- Thanks for the feedback; WJB, the point that you're making is exactly the point I've been making at WP:FAC. Rather than cluttering FACs with numerous green check marks throughout the FAC, the nominator could use half as many keystrokes to just type the word Done. This template probably serves a purpose elsewhere; the way it's being used as FAC is creating messy pages. SandyGeorgia (Talk) 09:36, 31 July 2007 (UTC)
Does the same thing need to be done for Template:Not done and Template:Doing? -- Reaper X 19:59, 4 August 2007 (UTC)
Green tick as opposed to Yes check
Could we possibly use instead of Yes check, ? It looks slightly better, what does everyone else think? –sebi 07:03, 8 August 2007 (UTC)
- Too bright. Just leave it alone. Might that screw up people with colour blindness anyway? -- Reaper X 08:19, 8 August 2007 (UTC)
- How exactly does it "screw up people with colour blindness"? A slightly brighter colour won't affect any person's current or future vision impairment in any way. –sebi 09:45, 9 August 2007 (UTC)
- Hmm.. i think I prefer the original actually. — nerdfighter(academy) 23:28, 24 February 2013 (UTC)
Subst?
Should this template be substed? CO2 16:50, 22 September 2007 (UTC)
- Yes, probably, unless used on a page where a Bot looks for {{Done}} before archiving requests (like WP:CHU). Still its such a short template that I doubt much extra server load is caused by it not being substituted (and it is fewer characters to type). WjBscribe 02:39, 25 September 2007 (UTC)
Edit request
{{editprotected}} Please change this template so there is a full stop after the done text, but I think its more appropriate for the full stop to not be in bold, and to be in regular text style. If this is performed, please apply this to Template:Not done. Cheers, Qst 13:01, 30 November 2007 (UTC)
- I don't think it always requires a full stop, and it's easily done without it being placed on the template itself - it's best left how it is. Ryan Postlethwaite 18:26, 1 December 2007 (UTC)
- Since the full stop is not a good idea, can there me added a break space after the e? It should not affect anything in a bad way, and I have seen the tempalte being used right before a letter (so the done merges with the next word without a breakspace). Nergaal (talk) 07:24, 27 January 2008 (UTC)
Interwiki link to ja
{{editprotected}}
Please add an interwiki link to the Japanese version of this template:
[[ja:Template:済]]
Thanks. --Nightshadow28 (talk) 12:50, 9 February 2008 (UTC)
- Done. I have moved the documentation to Template:Done/doc and have added it there. Thanks, mattbr 15:12, 9 February 2008 (UTC)
Category?
Any chance this template could be added to an appropriate category indicating usage (current one just indicates structure)? The category should link to a page in the Wikipedia namespace describing usage. --AlastairIrvine (talk) 15:52, 17 March 2008 (UTC)
Change
Would anyone have a problem if I made this template have the same look/feel as {{resolved}}. Reason being I often like to add a small comment after the check and the resolved version looks neater.
- Resolved– I sorted it out Khukri 07:09, 16 April 2008 (UTC)
- Done I sorted it out Khukri 07:09, 16 April 2008 (UTC)
Cheers Khukri 07:09, 16 April 2008 (UTC)
- That would probably send one of the templates to TfD, because why have two templates that look so much alike? -- Reaper X 16:26, 16 April 2008 (UTC)
- It's not to make them look alike it's the functionality and because the wording usage is for two entirely different situations. Done is something that required an action that was carried out, resolved is a problem solved. I use the two quite independently and miss having the the ability to put a minor comment next to the done box. Khukri 07:06, 17 April 2008 (UTC)
- {{done}} is ment to be used inline at the beginning of a comment, while {{resolved}} is used on top of a section/thread. They should not be made to look alike. — Edokter • Talk • 11:16, 22 April 2008 (UTC)
- Can't you use
{{resolved|Done}}
Resolved– Done
Hm no, well {{Doneb}} then:
. Rich Farmbrough, 11:05, 9 September 2009 (UTC).
Interwiki
Please add [[ko:틀:완료]].--Park4223 (talk) 17:10, 9 January 2010 (UTC)
- Done Note that the interwikis are listed on the /doc page, so anyone can edit it. —MC10 (T•C•GB•L) 02:45, 13 April 2010 (UTC)
diffs or it didn’t happen
I suppose we could add an optional parameter for revision number, something like:
'''{{#if:{{{2|}}} | [{{SERVER}}{{SCRIPTPATH}}/index.php?oldid={{{2}}}&diff=prev {{{1|Done}}}] | {{{1|Done}}} }}'''
―AoV² 20:21, 28 April 2010 (UTC)
Autosign
When these templates are used to mark off completed actions from a to-do list on a talkpage it is sometimes difficult to distinguish the signature appended to {{done}} from the original signature at the end of the list. It would seem helpful to have an option or default to put the editor's signature and timestamp inside the template, perhaps inside small tags to distinguish it or in hovertext. LeadSongDog come howl! 17:33, 13 May 2010 (UTC)
Template:Incomplete
Any way of getting an "incomplete" template? I could make one, but I wouldn't know what graphic to use. The actual {{incomplete}} template name is already taken, but the idea behind this is if I were to do half the work on a request and then let it be known that the request is still incomplete and the other half needs to be done. Maybe there's already something like this? – Kerαunoςcopia◁galaxies 11:10, 6 April 2011 (UTC)
- Maybe
{{half done}}
? I'm not sure about the symbol - maybe an amalgamation between the tick and the cross? — Tivedshambo (t/c) 08:56, 14 April 2011 (UTC)
- Or {{unfinished}}? As for symbol, here are a couple of galleries: User:Killervogel5/Icon_directory and User:Ezekiel63745/Icongallery. Some that might be relevant: I couldn't find one that looked like a pie with a missing piece, but those were the closest. Just some suggestions. – Kerαunoςcopia◁galaxies 19:07, 14 April 2011 (UTC)
- Ideally, the image should be public domain, so that the
link=
can be set (i.e. clicking on the image doesn't take you to the image page). See Wikipedia:Extended image syntax. — Tivedshambo (t/c) 19:36, 14 April 2011 (UTC)
- Ideally, the image should be public domain, so that the
- Ah, neat, I wondered why I couldn't sometimes click on an image. Ok, that makes sense. Maybe just a neutral X, then? Otherwise, I'm not sure how to search for all public domain icons on Wikipedia. – Kerαunoςcopia◁galaxies 20:37, 14 April 2011 (UTC)
Editprotected
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please remove from the category Category:Article message boxes. It is inappropriate. — This, that, and the other (talk) 08:03, 24 August 2011 (UTC)
- Actually, it appears that the problem does not lie in this template. But I can't find where it's coming from. — This, that, and the other (talk) 08:12, 24 August 2011 (UTC)
- It was coming from {{ambox}} which was coming from {{merge done}} which is used on the doc page. I added a nocat option, although I suppose {{merge done}} should just have the nocat hardcoded in it, since it isn't used in articles. Plastikspork ―Œ(talk) 04:53, 16 September 2011 (UTC)
Edit request from Baseball Watcher, 16 September 2011
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Can {{Partly done}} be added to the see also section?
Baseball Watcher 02:13, 16 September 2011 (UTC)
- Not done - you can do that on your own; the relevant page is Template:Done/doc. Magog the Ogre (talk) 02:54, 16 September 2011 (UTC)
"close" is a negative?
{{close}} produces a Closed negative/minus, same as those {{Declined}} Declined. I don't think that is a good association for Close. I'd expect something more neutral. -DePiep (talk) 10:31, 3 December 2013 (UTC)
Protected edit request on 9 March 2014
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please replace:
{{{{{|safesubst:}}}tick|18}} '''{{{{{|safesubst:}}}ucfirst:{{{1|Done}}}}}'''
with:
[[File:Yes check.svg|18px|link=]] '''{{{1|Done}}}'''
which will reduce the template include size weight of this template by 39 characters. 39 doesn't sound like much, but this template is currently used 9 times on Template:Admin dashboard which is adding 351 characters to the template expand problem noted Wikipedia:Village pump (technical)/Archive 124#Admin dashboard. — {{U|Technical 13}} (t • e • c) 22:55, 9 March 2014 (UTC)
- @Technical 13: How about adding
|alt=Yes
to the image invocation? According to this edit, it's important for people using screen readers. — Mr. Stradivarius ♪ talk ♪ 23:43, 9 March 2014 (UTC)- @Mr. Stradivarius:, I made exactly the same basic edit (different filename only) to {{Not done}} and inspecting the resulting img element reveals <img width="18" height="21" srcset="/upwiki/wikipedia/commons/thumb/a/a2/X_mark.s…kipedia/commons/thumb/a/a2/X_mark.svg/36px-X_mark.svg.png 2x" src="/upwiki/wikipedia/commons/thumb/a/a2/X_mark.svg/18px-X_mark.svg.png" alt="X mark.svg"></img> which shows that the "alt" parameter is set by the software. This means that screen readers will be able to read "X mark". Does it really need to be more specific? In the case of this template, it will say "Yes check", seems good to me, and saves us eight characters from template inclusion size... I'll wait for your response before carrying out this request, and if necessary add it to {{Not done}} as well. JD, is there any way the software could be modified to leave the file's extension out of the alt text when automatically populating that parameter? That is the only part of leaving it out that might be an issue for some readers (I know some recognize most extensions and have settings to ignore them). Thanks. — {{U|Technical 13}} (t • e • c) 00:11, 10 March 2014 (UTC)
- Good point. I've no objection in that case, particularly as there is also a request on Template talk:Tick to change the "Yes" alt text to "Green tick". And it seems someone has removed the alt text from Template:Cross as well. — Mr. Stradivarius ♪ talk ♪ 00:44, 10 March 2014 (UTC)
- Done Good good... Then this is done. :) — {{U|Technical 13}} (t • e • c) 01:34, 10 March 2014 (UTC)
- Good point. I've no objection in that case, particularly as there is also a request on Template talk:Tick to change the "Yes" alt text to "Green tick". And it seems someone has removed the alt text from Template:Cross as well. — Mr. Stradivarius ♪ talk ♪ 00:44, 10 March 2014 (UTC)
Template:Resbox wrapper
Any of the templates in the inline, content-level resolution tag family (like {{Done}} and {{Fixed}}) can now be converted on the fly into a bordered, thread-level resolution hatnote tag (like {{Resolved}}), with the Template:Resbox wrapper. — SMcCandlish ☺ ☏ ¢ ≽ʌⱷ҅ᴥⱷʌ≼ 13:38, 25 August 2014 (UTC)
Template-protected edit request on 21 April 2017
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please add |alt=Check mark icon
or similar phrase per MOS:ACCESS#Images. —Sangdeboeuf (talk) 22:43, 21 April 2017 (UTC)
- Done — xaosflux Talk 00:07, 22 April 2017 (UTC)
- Just a note for the record that I undid this change. Per Wikipedia:Alternative text for images#Examples, the icon is purely decorative and does not need alt text. --Ahecht (TALK
PAGE) 14:40, 2 October 2017 (UTC)
- Just a note for the record that I undid this change. Per Wikipedia:Alternative text for images#Examples, the icon is purely decorative and does not need alt text. --Ahecht (TALK
Template-protected edit request on 21 June 2018
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please remove the "<!--template:done-->
" HTML comment from this template. It only appears when the template is substituted, and in this case, it causes unnecessary clutter in the resulting source code. Thanks! ~ ToBeFree (talk) 19:16, 21 June 2018 (UTC)
- Additional note: If this is considered to be a good request, please also have a look at the other templates here: Template:Done/See_also -- some of them have the comment, some have not. I would suggest removing it from all of them. ~ ToBeFree (talk) 19:19, 21 June 2018 (UTC)
- Not done: The comment is intended to be in the substituted wikitext. — JJMC89 (T·C) 02:49, 22 June 2018 (UTC)
- I was about to say something like, "yes -- but why?", until I noticed that someone might, for example, substitute the "Done" template for automatic archival of a talk page. All right. It just looked strangely unrequired to me when I used it multiple times in the text body of a talk page message. I should also have started a short discussion here before using the request template. ~ ToBeFree (talk) 16:44, 24 June 2018 (UTC)
Alt text
Most of the templates listed in /see also have images but don't have alt text for them. Should they? --DannyS712 (talk) 21:31, 31 March 2019 (UTC)
Template-protected edit request on 18 April 2020
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please wrap the whole thing in a {{nowrap}}
. I'm seeing a check mark hanging in the last column of a line, and a bold "Done" leading off the next line.
This should be an uncontroversial request, because I can see that this was the original intent of the code—there is after all, a no-break space coded in the source—however, it isn't doing the job, for whatever reason. One of the test lines below should illustrate the point, if you jiggle the right margin of your browser appropriately:
- Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco labori Done
- Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud Done
- Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim Done
In addition, I note that this may affect multiple pages. I'm interested mainly in this one. If someone wants to be very thorough, the list of other affected templates containing check marks or other icons can be found at Template:Done/doc#See also. Thanks. Mathglot (talk) 20:20, 18 April 2020 (UTC)
- On further investigation: The generated code for the top test line is this:
...ullamco laboris nisi</span> <img ... />&160;<b>Done</b>
, but a non-break space does not work between an image, and text. (I believe that's because an image is a block element.) See, for example, this. Mathglot (talk) 21:28, 18 April 2020 (UTC)- I believe that I have resolved this one in the sandbox, but I know that this template is widely used in a variety of circumstances. I created a testcases page based on the examples above, but some examples of this template's use in the wild should probably be copied into the testcases page to make sure they still work fine. – Jonesey95 (talk) 03:24, 19 April 2020 (UTC)
- Andrybak, thank you(!) for the additional test cases. They all look functional to me. Do you have any reservations about moving the sandbox code into the live template? – Jonesey95 (talk) 18:11, 19 April 2020 (UTC)
- Jonesey95, could you please clarify why did you choose
<div>...</div>
withdisplay: inline
instead of a<span>...</span>
, which is what Template:nowrap uses? Or why not just use {{nowrap}} itself? —andrybak (talk) 06:27, 20 April 2020 (UTC)- I don't remember. I think I thought a span wouldn't work for some reason. If a span works, or if nowrap works, that is a better choice, since a div tag can't sit inside a span tag. Give it a try in the sandbox and check the testcases. – Jonesey95 (talk) 16:42, 20 April 2020 (UTC)
- My tests show that the present sandbox version where Andrybak reverted back to your version works very well to keep the check image with the
|1=
text. I vote we make it live, and over time other similar templates can be so updated. P.I. Ellsworth ed. put'r there 01:36, 21 April 2020 (UTC)- I changed the sandbox to use a span tag instead of a div tag, checked the testcases, and updated the live template. Again, I used a span tag instead of a div just in case someone put this template inside a template that uses span tags; div tags can't live inside of span tags. As for {{nowrap}}, I figured that it was better to use a plain span tag to reduce complexity and dependence on another template, since "span class=nowrap" is pretty simple text and doesn't need to take any options. I expect that this same model could be applied to other templates in this series. Note that I wrapped only the checkmark and the "Done" or alternate
|1=
text in the nowrap tags. I left the|reason=
contents outside of the nowrap, figuring that it would be undesirable to wrap long reason= text strings. – Jonesey95 (talk) 02:27, 21 April 2020 (UTC)- To editors Jonesey95 and Andrybak: excellent! Seems to work beautifully! P.I. Ellsworth ed. put'r there 05:06, 21 April 2020 (UTC)
- I changed the sandbox to use a span tag instead of a div tag, checked the testcases, and updated the live template. Again, I used a span tag instead of a div just in case someone put this template inside a template that uses span tags; div tags can't live inside of span tags. As for {{nowrap}}, I figured that it was better to use a plain span tag to reduce complexity and dependence on another template, since "span class=nowrap" is pretty simple text and doesn't need to take any options. I expect that this same model could be applied to other templates in this series. Note that I wrapped only the checkmark and the "Done" or alternate
- My tests show that the present sandbox version where Andrybak reverted back to your version works very well to keep the check image with the
- I don't remember. I think I thought a span wouldn't work for some reason. If a span works, or if nowrap works, that is a better choice, since a div tag can't sit inside a span tag. Give it a try in the sandbox and check the testcases. – Jonesey95 (talk) 16:42, 20 April 2020 (UTC)
- Jonesey95, could you please clarify why did you choose
- Andrybak, thank you(!) for the additional test cases. They all look functional to me. Do you have any reservations about moving the sandbox code into the live template? – Jonesey95 (talk) 18:11, 19 April 2020 (UTC)
- I believe that I have resolved this one in the sandbox, but I know that this template is widely used in a variety of circumstances. I created a testcases page based on the examples above, but some examples of this template's use in the wild should probably be copied into the testcases page to make sure they still work fine. – Jonesey95 (talk) 03:24, 19 April 2020 (UTC)
Bug? - problems with only check mark (done and no message)
Hello, there is a problem if you keep the message empty:
code | result |
---|---|
{{done|}} |
It renders a small '
after the check mark, can't find an answer in the code, anyone else? Thx and Regards--W like wiki good to know 21:47, 7 February 2023 (UTC)
- Fixed. Thanks for the bug report. – Jonesey95 (talk) 22:07, 7 February 2023 (UTC)
- @Jonesey95: woow, that was quite fast Great! So tricky sometimes with those little differences between space there not there. Thx! --W like wiki good to know 22:24, 7 February 2023 (UTC)
Edit request 16 May 2023
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Description of suggested change: add new variant of Done check icon with text Resolved like Resolved. It's helpful if the issue was resolved without editing the article so you can't just say Done. Eurohunter (talk) 17:47, 16 May 2023 (UTC)
Diff:
− | + | CHANGED_TEXT |
Eurohunter (talk) 17:47, 16 May 2023 (UTC)
- There's already
- {{resolved}}Resolved
- Resolved {{resolved mark}}
- 73.93.5.246 (talk) 18:10, 16 May 2023 (UTC)